Change nginx instrumentation into command line #2777
Conversation
|
Hey 😃 |
|
The instrumentation was off by default, so you'll need to update some tests to re-enable it. You can look at #2750 as an example. |
Hey @TylerHelmuth thank you for the advice, I had a look at the pull request you said and performed the required changes. However the tests were still failing so I found that we were activating the feature gate in config/manager/manager.yaml , which after its removal was no longer valid. So I removed it and no the e2e tests are passing ✅ Please tell me if the solution I found was the right one or if there is something else I should do 🙏 |
|
It looks like we have both the Go and the Nginx autoinstrumentations enabled in our release manifests, I believe unintentionally? If I recall correctly, the intent was to just enable them in E2E tests, right @TylerHelmuth ? In that case, we should probably just accept this state of affairs and set the flags themselves to be enabled by default. WDYT @jaronoff97 @pavolloffay ? To be clear, I think this PR can be merged as-is, it's not changing the current behaviour. |
Correct. |
|
Hey 😃 |
| component: operator | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: change nginx instrumentation feature gate into command line flag --enable-nginx-instrumentation |
There was a problem hiding this comment.
Please mention here what is the feature gate flag that is being changed.
* feat: change nginx instrumentation to cli flag * set nginx instrumentation to default false * update config/manager * enable nginx in config/manager * update chloggen
Description:
Change nginx instrumentation into command line
Link to tracking Issue(s):
#2676
operator.autoinstrumentation.nginx#2676Testing:
Documentation: