App for TA collector mtls e2e tests #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
reviewed
Aug 19, 2024
swiatekm
approved these changes
Aug 19, 2024
There was a problem hiding this comment.
Would be nice to add a short README.md to the directory, explaining what this is for, as it's not immediately obvious from the code.
Other than that, this looks good to me. I considered using some off the shelf application instead, but I think that'd be a comparable amount of work, and less clarity on how it was used.
@pavolloffay @jaronoff97 can you check this out and see if you're ok with it?
jaronoff97
approved these changes
Aug 22, 2024
|
this looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: New app for testing that the collector was able to get secret auth details from the target allocator when communication is done over mTLS
Part of a solution for #1669
Testing:
Documentation: