Update chainsaw in makefile #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavolloffay
commented
Oct 11, 2024
pavolloffay
added
the
Skip Changelog
swiatekm
approved these changes
Oct 11, 2024
jaronoff97
approved these changes
Oct 11, 2024
frzifus
approved these changes
Oct 13, 2024
|
@pavolloffay these two tests keep failing, but i do not know why... any ideas? |
I will use a lower version |
pavolloffay
force-pushed
the
update-chainsaw
branch
from
a2ce78b to
df8edd6
Compare
pavolloffay
commented
Oct 18, 2024
| @@ -62,8 +62,6 @@ jobs: | |||
| with: | |||
| path: bin | |||
| key: ${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('Makefile') }}-${{ steps.setup-go.outputs.go-version }} | |||
| - name: Install chainsaw | |||
There was a problem hiding this comment.
the way our makefile is written this is not needed, actually it confuses which version is used.
pavolloffay
commented
Oct 18, 2024
| @@ -473,7 +473,7 @@ KUSTOMIZE_VERSION ?= v5.0.3 | |||
| CONTROLLER_TOOLS_VERSION ?= v0.16.1 | |||
| GOLANGCI_LINT_VERSION ?= v1.57.2 | |||
| KIND_VERSION ?= v0.20.0 | |||
| CHAINSAW_VERSION ?= v0.2.5 | |||
| CHAINSAW_VERSION ?= v0.2.8 | |||
There was a problem hiding this comment.
It seems like 0.2.9 requires go 1.23 https://github.com/kyverno/chainsaw/releases/tag/v0.2.9 so we can updated only to 0.2.8
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
update-chainsaw
branch
from
da891a3 to
e2dacce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue(s):
Testing:
Documentation: