Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1beta1: apply telemetry config defaults in webhook #3361

Merged
merged 1 commit into from
Oct 19, 2024
Merged

v1beta1: apply telemetry config defaults in webhook #3361

merged 1 commit into from
Oct 19, 2024

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Oct 17, 2024 •
edited
Loading

Description:

  • Set default metric address in telemetry settings
  • Provide an upgrade routine for v0.111.0

Link to tracking Issue(s):

Testing:

Documentation:

@frzifus frzifus force-pushed the default_telemetry_settings branch 5 times, most recently from 65437b7 to d6a64bd Compare October 17, 2024 21:01
@frzifus frzifus marked this pull request as ready for review October 17, 2024 21:10
@frzifus frzifus requested a review from a team as a code owner October 17, 2024 21:10
@frzifus frzifus force-pushed the default_telemetry_settings branch from d6a64bd to 7dc5687 Compare October 17, 2024 21:30
pavolloffay
pavolloffay reviewed Oct 18, 2024
View reviewed changes
.chloggen/default_telemetry_settings.yaml Outdated Show resolved Hide resolved
apis/v1beta1/config.go Outdated Show resolved Hide resolved
@frzifus frzifus requested a review from pavolloffay October 18, 2024 08:10
@frzifus frzifus force-pushed the default_telemetry_settings branch from 910ca50 to 5e93b88 Compare October 18, 2024 10:15
@frzifus frzifus requested a review from pavolloffay October 18, 2024 10:18
swiatekm
swiatekm approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few minor nitpicks.

apis/v1beta1/config.go Outdated Show resolved Hide resolved
apis/v1beta1/config.go Show resolved Hide resolved
pkg/collector/upgrade/v0_111_0_test.go Outdated Show resolved Hide resolved
@frzifus frzifus force-pushed the default_telemetry_settings branch from 31488ac to 8abca77 Compare October 18, 2024 14:03
@frzifus
v1beta1: apply telemetry config defaults in webhook
57203dd 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

Update .chloggen/default_telemetry_settings.yaml

add another webhook test

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

avoid using mapstructure

Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

test: assert on addr
@frzifus frzifus force-pushed the default_telemetry_settings branch from 8abca77 to 57203dd Compare October 18, 2024 14:50
@jaronoff97 jaronoff97 merged commit 5a11b48 into open-telemetry:main Oct 19, 2024
36 checks passed
@frzifus frzifus deleted the default_telemetry_settings branch October 19, 2024 06:33
@alexkruc alexkruc mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@pavolloffay pavolloffay pavolloffay approved these changes

@iblancasa iblancasa iblancasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frzifus @iblancasa @pavolloffay @jaronoff97 @swiatekm