Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nodejs auto-instrumentation support for linux/s390x,linux/ppc64le #3362

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add nodejs auto-instrumentation support for linux/s390x,linux/ppc64le #3362

merged 2 commits into from
Oct 22, 2024

Conversation

pavolloffay
Copy link
Member

Description:

Link to tracking Issue(s):

Testing:

Documentation:

@pavolloffay
Add nodejs auto-instrumentation support for linux/s390x,linux/ppc64le
108999f 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested a review from a team as a code owner October 17, 2024 13:12
@pavolloffay pavolloffay mentioned this pull request Oct 17, 2024
Closed
swiatekm
swiatekm reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that this actually works? It does appear to build correctly.

@pavolloffay pavolloffay requested a review from iblancasa October 17, 2024 13:33
@pavolloffay
Copy link
Member Author

no, this was best effort :)

@swiatekm
Copy link
Contributor

Putting aside Kubernetes, are we even sure the JS instrumentation supports these architectures?

Or, to put it a different way, why make this change at all?

@pavolloffay
Copy link
Member Author

@IshwarKanse will look into testing this

@pavolloffay
Copy link
Member Author

There are some references so hopefully it works https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-js%20s390x&type=code. nodejs should be cross platform

@IshwarKanse
Copy link
Contributor

Working on this to verify on the IBM platforms today.

@IshwarKanse
Copy link
Contributor

@pavolloffay Verified on linux/s390x,linux/ppc64le clusters. We are good to merge this PR.

@pavolloffay pavolloffay merged commit 698b078 into open-telemetry:main Oct 22, 2024
37 checks passed
@alexkruc alexkruc mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@frzifus frzifus frzifus approved these changes

@iblancasa iblancasa iblancasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autoinstrumentation nodejs no image found in image index for architecture ppc64le
5 participants
@pavolloffay @swiatekm @IshwarKanse @iblancasa @frzifus