Support configuring java runtime from configmap or secret (env.valueFrom) #3379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaronoff97
reviewed
Oct 22, 2024
| - name: OTEL_JAVAAGENT_DEBUG | ||
| value: "true" | ||
| - name: OTEL_INSTRUMENTATION_JDBC_ENABLED | ||
| value: "false" | ||
| - name: SPLUNK_PROFILER_ENABLED | ||
| value: "false" | ||
| - name: JAVA_TOOL_OPTIONS | ||
| value: ' -javaagent:/otel-auto-instrumentation-java/javaagent.jar' | ||
| value: '$(JAVA_TOOL_OPTIONS) -javaagent:/otel-auto-instrumentation-java/javaagent.jar' |
There was a problem hiding this comment.
are we able to verify that this works? I didn't think that additive variables with the same name work?
There was a problem hiding this comment.
it works, we are even using it for getting the pod name and namespace to resource attributes env var
There was a problem hiding this comment.
There was a problem hiding this comment.
I think Jacob was asking if defining the same variable twice works as one would intuitively expect here.
I tested it, and it does work, but we should really leave a comment in the code explaining this. It seems very weird at first glance.
There was a problem hiding this comment.
I have added the link into the source code.
As I mention we already use it for other env vars
…rom) Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
force-pushed
the
otel-configmap
branch
from
bce549d to
1b5b986
Compare
|
PR updated |
swiatekm
approved these changes
Oct 25, 2024
jaronoff97
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Supersedes #3373
This PR is much simpler it does not require fetching configmaps/secrets.
If the
JAVA_TOOL_OPTIONSis set (e.g. from configmap the operator sets anotherJAVA_TOOL_OPTIONS=$(JAVA_TOOL_OPTIONS) -javaagentLink to tracking Issue(s):
Testing:
Documentation: