-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Test OpenTelemetry must-gather script #3387
Conversation
cc @iblancasa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this makes sense, but i'm wondering if we can try going one step further and checking that we get the expected metrics from the must gather? (i'm working on this in #3381 and would love us to do more of this)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, had some relatively minor comments.
2d2827c
to
2264638
Compare
2264638
to
409ad4a
Compare
@jaronoff97 The must-gather doesn't expose any metrics. It is used for collecting troubleshooting info from the operator instance like the CR instances, configs, operator logs etc. |
Description:
The PR adds tests for OpenTelemetry Operator must-gather script, which collects troubleshooting data from the operator and CR instances.