Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Test OpenTelemetry must-gather script #3387

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

IshwarKanse
Copy link
Contributor

Description:
The PR adds tests for OpenTelemetry Operator must-gather script, which collects troubleshooting data from the operator and CR instances.

--- PASS: chainsaw (89.11s)
    --- PASS: chainsaw/otlp-metrics-traces (89.11s)
    --- PASS: chainsaw/must-gather (76.85s)
PASS
Tests Summary...
- Passed  tests 2
- Failed  tests 0
- Skipped tests 0
Done.

@IshwarKanse IshwarKanse requested a review from a team as a code owner October 24, 2024 05:53
@IshwarKanse
Copy link
Contributor Author

cc @iblancasa

Copy link
Contributor

@jaronoff97 jaronoff97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this makes sense, but i'm wondering if we can try going one step further and checking that we get the expected metrics from the must gather? (i'm working on this in #3381 and would love us to do more of this)

Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, had some relatively minor comments.

tests/e2e-openshift/must-gather/check_must_gather.sh Outdated Show resolved Hide resolved
tests/e2e-openshift/must-gather/chainsaw-test.yaml Outdated Show resolved Hide resolved
tests/e2e-openshift/must-gather/chainsaw-test.yaml Outdated Show resolved Hide resolved
tests/e2e-openshift/must-gather/chainsaw-test.yaml Outdated Show resolved Hide resolved
@IshwarKanse
Copy link
Contributor Author

@jaronoff97 The must-gather doesn't expose any metrics. It is used for collecting troubleshooting info from the operator instance like the CR instances, configs, operator logs etc.

@swiatekm swiatekm merged commit 3ab821e into open-telemetry:main Oct 28, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants