Generate only TargetAllocator CR from Collector CR #3402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
feat/ta-crd-feature-flag
branch
from
e342ad5 to
e92527f
Compare
swiatekm
force-pushed
the
feat/ta-crd-feature-flag
branch
from
e92527f to
c1e6ecd
Compare
jaronoff97
approved these changes
Oct 28, 2024
Comment on lines
+184
to
+187
| // watch collectors which have embedded Target Allocator enabled | ||
| // we need to do this separately from collector reconciliation, as changes to Config will not lead to changes | ||
| // in the TargetAllocator CR | ||
| ctrlBuilder.Watches( |
There was a problem hiding this comment.
didn't realize the controller has this capability, very cool :)
There was a problem hiding this comment.
It is only implemented in software here, so we get every update, and then the ones where the condition isn't true are discarded. But that's not really a problem in this case.
swiatekm
force-pushed
the
feat/ta-crd-feature-flag
branch
from
c1e6ecd to
2fc677d
Compare
This is hidden behind a feature flag. Nothing changes by default.
swiatekm
force-pushed
the
feat/ta-crd-feature-flag
branch
from
2fc677d to
d2d4ed4
Compare
araiu
added a commit
to araiu/opentelemetry-helm-charts
that referenced
this pull request
Dec 5, 2024
* `secrets`: Add TLS support to auto-instrumentation [#3338](open-telemetry/opentelemetry-operator#3338) * `targetallocators`: Generate only TargetAllocator CR from Collector CR [#3402](open-telemetry/opentelemetry-operator#3402)
araiu
added a commit
to araiu/opentelemetry-helm-charts
that referenced
this pull request
Dec 5, 2024
* `secrets`: Add TLS support to auto-instrumentation [#3338](open-telemetry/opentelemetry-operator#3338) * `targetallocators`: Generate only TargetAllocator CR from Collector CR [#3402](open-telemetry/opentelemetry-operator#3402)
araiu
added a commit
to araiu/opentelemetry-helm-charts
that referenced
this pull request
Dec 5, 2024
* `secrets`: Add TLS support to auto-instrumentation [#3338](open-telemetry/opentelemetry-operator#3338) * `targetallocators`: Generate only TargetAllocator CR from Collector CR [#3402](open-telemetry/opentelemetry-operator#3402)
araiu
added a commit
to araiu/opentelemetry-helm-charts
that referenced
this pull request
Dec 6, 2024
* `secrets`: Add TLS support to auto-instrumentation [#3338](open-telemetry/opentelemetry-operator#3338) * `targetallocators`: Generate only TargetAllocator CR from Collector CR [#3402](open-telemetry/opentelemetry-operator#3402)
TylerHelmuth
pushed a commit
to open-telemetry/opentelemetry-helm-charts
that referenced
this pull request
Dec 6, 2024
* Release operator 0.114.1 Signed-off-by: Alex Raiu <raiu.andrei@protonmail.com> * Update operator clusterrole * `secrets`: Add TLS support to auto-instrumentation [#3338](open-telemetry/opentelemetry-operator#3338) * `targetallocators`: Generate only TargetAllocator CR from Collector CR [#3402](open-telemetry/opentelemetry-operator#3402) * Add `targetAllocatorFallbackStrategy` feature flag Feature flag available since `v0.114.0` (Add allocation_fallback_strategy option as fallback strategy for per-node strategy [#3482](open-telemetry/opentelemetry-operator#3482)) * Update operator-test with manager label Adding `control-plane: controller-manager` label to match [operator-restart e2e test](open-telemetry/opentelemetry-operator#3486) --------- Signed-off-by: Alex Raiu <raiu.andrei@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently when the target allocator is enabled on the collector CR, the collector reconciler generates the target allocator manifests directly. This PR introduces a feature flag that causes it to generate a Target Allocator CR instead, and lets the Target Allocator reconciler take care of the rest.
All the changes are gated behind the flag, including actually enabling the TA controller and webhook. Users who don't set the flag are completely unaffected.
I'm not adding a changelog entry for this, because it's only really meant for testing. I'll add the entry alongside the documentation when we actually enable the controller and webhook unconditionally.
Link to tracking Issue(s):
Testing:
Added: