Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Fix assert for multi-cluster test #3481

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

IshwarKanse
Copy link
Contributor

Description:
For the multi-cluster test, the Kubernetes job completion status has changed in OCP 4.18

status:
  completionTime: "2024-11-21T05:35:45Z"
  conditions:
  - lastProbeTime: "2024-11-21T05:35:45Z"
    lastTransitionTime: "2024-11-21T05:35:45Z"
    message: Reached expected number of succeeded pods
    reason: CompletionsReached
    status: "True"
    type: SuccessCriteriaMet
  - lastProbeTime: "2024-11-21T05:35:45Z"
    lastTransitionTime: "2024-11-21T05:35:45Z"
    message: Reached expected number of succeeded pods
    reason: CompletionsReached
    status: "True"
    type: Complete
  ready: 0
  startTime: "2024-11-21T05:35:41Z"
  succeeded: 1
  terminating: 0
  uncountedTerminatedPods: {} 

This condition is not available anymore:

status:
  conditions:
    - status: "True"
      type: Complete 

The PR updates the test to use an assert which works both with OCP 4.18 and older OCP versions.

@IshwarKanse IshwarKanse requested a review from a team as a code owner November 21, 2024 07:24
@swiatekm swiatekm merged commit 5cab636 into open-telemetry:main Nov 21, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants