Add statsd receiver #364
Merged
Add statsd receiver #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
reviewed
Aug 4, 2021
CONTRIBUTING.md
Outdated
| @@ -85,6 +85,8 @@ For a general overview of the directories from this operator and what to expect | |||
|
|
|||
| Your contribution is welcome! For it to be accepted, we have a few standards that must be followed. | |||
|
|
|||
| If you are contributing to sync the receivers from [otel-collector-contrib](https://github.com/open-telemetry/opentelemetry-collector-contrib). Operator only syncs receivers that aren't scrapers. As operator has nothing to do with scrapers. whereas with general receivers, operator exposes the port in kubernetes service object as specified in the receiver's config. | |||
There was a problem hiding this comment.
Suggested change
| If you are contributing to sync the receivers from [otel-collector-contrib](https://github.com/open-telemetry/opentelemetry-collector-contrib). Operator only syncs receivers that aren't scrapers. As operator has nothing to do with scrapers. whereas with general receivers, operator exposes the port in kubernetes service object as specified in the receiver's config. | |
| If you are contributing to sync the receivers from [otel-collector-contrib](https://github.com/open-telemetry/opentelemetry-collector-contrib), note that the operator only synchronizes receivers that aren't scrapers, as there's no need to open ports in services for this case. In general, receivers would open a UDP/TCP port and the operator should be adding an entry in the Kubernetes Service resource accordingly. |
|
@VineethReddy02 what's the status of this one? |
|
I will update the suggested change and will rebase the PR. :) |
jpkrohling
approved these changes
Aug 19, 2021
shree007
pushed a commit
to shree007/opentelemetry-operator
that referenced
this pull request
Dec 12, 2021
* add statsd receiver * update notes on syncing up receivers in CONTRIBUTING.md
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* add statsd receiver * update notes on syncing up receivers in CONTRIBUTING.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statsd receiver
As part of #128