-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the default port for OTLP HTTP #373
Conversation
And marking the existing as legacy.
Hey all,
My Go installation is: I'm rather new to go, so sorry if this is a stupid question 🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I don't see the same problem as you are seeing. I do get a test failure, though:
|
I found the issue you are facing: you can reproduce it by running |
Nice, thanks @jpkrohling ! I'll fix the tests later today and publish the PR. |
Pull request has been modified.
* Change the default port for OLTP http And marking the existing as legacy. * Fix tests
* Change the default port for OLTP http And marking the existing as legacy. * Fix tests
From the issue:
resolves #371