Fix issue in name trimming not adding all values #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
approved these changes
Dec 17, 2021
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #596
In the previous PR for this issue a case was missed when submitting the name trimming code.
This issue caused, in certain cases, an error where
fmt.Sprintf()would receive less values that the format expected and would therefore have a missing parameter.The result of this are formatted texts that look like this:
--- FAIL: TestTruncate (0.00s) --- FAIL: TestTruncate/first_value_gets_truncated,_second_added (0.00s) /home/mihai/projects/open-telemetry/opentelemetry-operator/pkg/naming/triming_test.go:78: Error Trace: triming_test.go:78 Error: Not equal: expected: "4d96-11ea-b174-c85b7644b6b5-5d0c1e62-4d96-11ea-b174--collector" actual : "4d96-11ea-b174-c85b7644b6b5-5d0c1e62-4d96-11e-%!s(MISSING)-coll" Diff: --- Expected +++ Actual @@ -1 +1 @@ -4d96-11ea-b174-c85b7644b6b5-5d0c1e62-4d96-11ea-b174--collector +4d96-11ea-b174-c85b7644b6b5-5d0c1e62-4d96-11e-%!s(MISSING)-coll Test: TestTruncate/first_value_gets_truncated,_second_added FAIL FAIL github.com/open-telemetry/opentelemetry-operator/pkg/naming 0.015s FAILNotice the
%!s(MISSING). This would also cause the labels to fail when such a case was encountered during execution.