Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel Operator release 0.43.0 #680

Merged
merged 21 commits into from
Feb 10, 2022
Merged

Conversation

yuriolisa
Copy link
Contributor

@yuriolisa yuriolisa commented Jan 28, 2022

Resolves #679

@yuriolisa yuriolisa requested review from a team and codeboten January 28, 2022 09:14
@yuriolisa
Copy link
Contributor Author

I'm wondering if I should prepare a routine upgrade for the following change:

open-telemetry/opentelemetry-collector#4695

@pavolloffay, @jpkrohling, @VineethReddy02

@pavolloffay
Copy link
Member

pavolloffay commented Jan 28, 2022

I'm wondering if I should prepare a routine upgrade for the following change:

open-telemetry/opentelemetry-collector#4695

+1

@mcariapas
Copy link
Contributor

mcariapas commented Feb 2, 2022

I see readyReplicas has been removed from Deployment status, can you update e2e tests please?
--- FAIL: kuttl/harness/smoke-restarting-deployment (152.28s)
--- FAIL: kuttl/harness/smoke-pod-annotations (157.24s)
--- FAIL: kuttl/harness/smoke-simplest (150.96s)

Update:
Tests are unstable. Deployment has no time to get up to ready status before being checked.
@pavolloffay can we try to re-run them as a temporary solution?

@jpkrohling
Copy link
Member

Tests restarted.

@VineethReddy02
Copy link
Contributor

@yuriolisa can you create the upgrade routine PR for 0.43.0 release?

@yuriolisa
Copy link
Contributor Author

Hi @VineethReddy02, I was involved with another project last week. I'll be working on that today.

@yuriolisa
Copy link
Contributor Author

@pavolloffay , @VineethReddy02 , @jpkrohling . Could you please review this PR?

@alolita
Copy link
Member

alolita commented Feb 8, 2022

What is the status on this PR? We're blocked on an Operator release - should this PR be closed and a 0.44 release be started? We can help with releases :-)

@jpkrohling
Copy link
Member

We can help with releases :-)

Working on the 0.44.0 release might be a good exercise for @erichsueh3.

pkg/collector/upgrade/v0_43_0_test.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jpkrohling
Copy link
Member

The linting check is still failing. Could you also please add #697 as part of the changelog?

pkg/collector/upgrade/v0_43_0_test.go Outdated Show resolved Hide resolved
pkg/collector/upgrade/v0_43_0_test.go Show resolved Hide resolved
pkg/collector/upgrade/v0_43_0.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@alolita
Copy link
Member

alolita commented Feb 9, 2022

Thanks for the excellent suggestion @jpkrohling! @erichsueh3 pl shadow @yuriolisa to help with the releases.

@yuriolisa
Copy link
Contributor Author

@alolita, I'll help @erichsueh3 on the next release.

@erichsueh3
Copy link
Contributor

@yuriolisa @jpkrohling sounds good!

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/collector/upgrade/v0_43_0.go Show resolved Hide resolved
@yuriolisa
Copy link
Contributor Author

@VineethReddy02 , could you please review it again?

Copy link
Contributor

@VineethReddy02 VineethReddy02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few indentation nits. Overall LGTM!

pkg/collector/upgrade/v0_43_0.go Outdated Show resolved Hide resolved
pkg/collector/upgrade/v0_43_0.go Outdated Show resolved Hide resolved
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please clean the empty lines like @VineethReddy02 suggested. It helps with readability.

@jpkrohling jpkrohling merged commit 6787b10 into open-telemetry:main Feb 10, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
* Otel Operator release 0.43.0

* Fixing typo

* Upgrade script to version 0.43.0

* Including versions reference

* Fixing Lint tests

* Adding metrics changes into CHANGELOG

* Removed comment and fixed changelog

* Added new PR on Changelog and added lint fixes

* Added missing header

* Fixing upgrade routine

* Adding missing operator-sdk PR

* Change method of sorting args and fixing test

* fixing test logic

* Change method of sorting args and fixing test

* Fixed Changelog links

* Fixed Changelog links

* Change lint format on version tests

* Fixed typos on test

* Fixed typos on test

* Fixed Changelog and added description in test file

* Removed empty lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release 0.43.0
7 participants