Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nodejs instrumentation to 0.27.0 #687

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Update nodejs instrumentation to 0.27.0 #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/publish-autoinstrumentation-nodejs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
- '.github/workflows/publish-autoinstrumentation-nodejs.yaml'
branches:
- main
pull_request:
paths:
- 'autoinstrumentation/nodejs/**'
- '.github/workflows/publish-autoinstrumentation-nodejs.yaml'
workflow_dispatch:

jobs:
Expand Down Expand Up @@ -38,7 +42,7 @@ jobs:
uses: docker/build-push-action@v2.8.0
with:
context: autoinstrumentation/nodejs
push: true
push: ${{ github.event_name == 'push' }}
build-args: version=${{ env.VERSION }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
8 changes: 4 additions & 4 deletions autoinstrumentation/nodejs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@
"typescript": "^4.4.4"
},
"dependencies": {
"@opentelemetry/api": "1.0.3",
"@opentelemetry/auto-instrumentations-node": "0.26.0",
"@opentelemetry/exporter-otlp-grpc": "0.26.0",
"@opentelemetry/sdk-node": "0.26.0"
"@opentelemetry/api": "1.0.4",
"@opentelemetry/auto-instrumentations-node": "0.27.2",
"@opentelemetry/exporter-trace-otlp-grpc": "0.27.0",
"@opentelemetry/sdk-node": "0.27.0"
}
}
2 changes: 1 addition & 1 deletion autoinstrumentation/nodejs/src/autoinstrumentation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node';
import { OTLPTraceExporter } from '@opentelemetry/exporter-otlp-grpc';
import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-grpc';

import { NodeSDK } from '@opentelemetry/sdk-node';

Expand Down
1 change: 1 addition & 0 deletions autoinstrumentation/nodejs/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"noImplicitReturns": true,
"noUnusedLocals": true,
"pretty": true,
"skipLibCheck": true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, TS does a deep typecheck through transitive dependencies. I don't know if it's a but in opentelemetry-js (/cc @dyladan) but after updating I got a transitive type failure on graphql library.

For our meager code, the transitive type check is definitely not needed.

https://www.typescriptlang.org/tsconfig#skipLibCheck

"sourceMap": true,
"strict": true,
"strictNullChecks": true,
Expand Down