Bump operator-sdk to 1.17 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove admissionregistration.k8s.io/v1beta1 removed from 1.22, v1 was added in 1.16 * Remove crd:trivialVersions=true,preserveUnknownFields=false" that produce CRDs compatible with 1.11 Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
commented
Feb 8, 2022
| @@ -15,11 +15,18 @@ spec: | |||
| - "--secure-listen-address=0.0.0.0:8443" | |||
| - "--upstream=http://127.0.0.1:8080/" | |||
| - "--logtostderr=true" | |||
| - "--v=10" | |||
| - "--v=0" | |||
There was a problem hiding this comment.
pavolloffay
commented
Feb 8, 2022
| @@ -2,7 +2,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.6.0-beta.0 | |||
| controller-gen.kubebuilder.io/version: v0.8.0 | |||
There was a problem hiding this comment.
pavolloffay
commented
Feb 8, 2022
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
@VineethReddy02 @jpkrohling this is ready for review. |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
Can you ping me again once the CI passes? I'll then review and merge this PR. |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
@jpkrohling all green now! |
jpkrohling
reviewed
Feb 8, 2022
jpkrohling
approved these changes
Feb 8, 2022
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
* Bump operator-sdk to 1.14 * Remove admissionregistration.k8s.io/v1beta1 removed from 1.22, v1 was added in 1.16 * Remove crd:trivialVersions=true,preserveUnknownFields=false" that produce CRDs compatible with 1.11 Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Bump operator-sdk to 1.17.0 Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Fix Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * remove wait Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * fix lint Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Add phony Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * install tools only to ./bin Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * use go install Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * guide Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * remove ech Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * remvoe deprecation Signed-off-by: Pavol Loffay <p.loffay@gmail.com> * Remove comment Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps operator-skd from 1.13 to 1.17. It follows the SDK upgrade docs and aligns project with those changes.
Notable changes:
./binenvtestrequire additional settings based on the k8s version used in the makefile - added contributing docsadmissionregistration.k8s.io/v1beta1, now onlyv1is supported (as part of operator-sdk 1.14 upgrade). Thev1beta1was removed in 1.22 and deprecated in 1.16 (addedv1). OpenShift 4.6 LTS is based on k8s 1.19.1.17 update
1.14 update
Signed-off-by: Pavol Loffay p.loffay@gmail.com