Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appProtocol for otlp and jaeger receiver parsers #704

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

binjip978
Copy link
Contributor

Signed-off-by: Sergei Semenchuk pdp.eleven11@gmail.com

@binjip978 binjip978 requested review from a team and dmitryax February 10, 2022 08:00
Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

if you could fix as well Zipkin that would be great, it's often times used in service mesh.

It would be great as well improve e2e test and assert the service e.g. https://github.com/open-telemetry/opentelemetry-operator/blob/main/tests/e2e/smoke-simplest/00-assert.yaml

@VineethReddy02
Copy link
Contributor

@binjip978
Copy link
Contributor Author

Few tests are failing in the CI more details: https://github.com/open-telemetry/opentelemetry-operator/runs/5137930906?check_suite_focus=true#step:7:776

yeah, it's quite tricky to run the full suite on mac, but it should be fine now.

@binjip978
Copy link
Contributor Author

LGTM,

if you could fix as well Zipkin that would be great, it's often times used in service mesh.

It would be great as well improve e2e test and assert the service e.g. https://github.com/open-telemetry/opentelemetry-operator/blob/main/tests/e2e/smoke-simplest/00-assert.yaml

for the zipkin part, I'm not really familiar with it and looks like it use GenericReceiver, so it's possible to setup TCP if the name is zipkin, but I'm not sure about appProtocol, it should be http, http2 or grcp? Looks like it depends https://zipkin.io/pages/tracers_instrumentation

@pavolloffay
Copy link
Member

Zipkin uses http

Copy link
Member

@pavolloffay pavolloffay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the e2e test- verify the service has the protocol set.

@@ -53,6 +53,16 @@ func (g *GenericReceiver) Ports() ([]corev1.ServicePort, error) {
}

if g.defaultPort > 0 {
if g.name == "zipkin" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this approach. The protocol type should be rather set in

and then just used to configure the service

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pavolloffay just to be clear for zipkin config we can expect something like this:

zipkin:
---
zipkin:
  protocols:
    http:
      endpoint: "0.0.0.0:9999"

And in case of default config "zipkin:" is this ok to add to GenericReceiver fields like defaultProtocol and defaultAppProtocol?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will have to add a field there

Signed-off-by: Sergei Semenchuk <pdp.eleven11@gmail.com>
@pavolloffay pavolloffay merged commit 6faf246 into open-telemetry:main Feb 21, 2022
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
)

Signed-off-by: Sergei Semenchuk <pdp.eleven11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants