OTEL Operator release 0.44.0 #719
Conversation
|
Looked through the Collector's changelog, and I don't think there are any migration steps necessary. Though, still unsure what exactly qualifies as a migration step, if someone could clear that up so I can understand for future reference that'd be great! |
|
Not sure why the CI is failing, says that |
bundle.Dockerfile
Outdated
| @@ -6,7 +6,7 @@ LABEL operators.operatorframework.io.bundle.manifests.v1=manifests/ | |||
| LABEL operators.operatorframework.io.bundle.metadata.v1=metadata/ | |||
| LABEL operators.operatorframework.io.bundle.package.v1=opentelemetry-operator | |||
| LABEL operators.operatorframework.io.bundle.channels.v1=alpha | |||
| LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.16.0+git | |||
| LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.17.0 | |||
There was a problem hiding this comment.
@erichsueh3 please install operator-sdk 1.17.0 and re-generate the manifest files. This will fix the issue with CI..
There was a problem hiding this comment.
Hi @pavolloffay, these manifest files were generated after installing operator-sdk 1.17.0; I've done it again just to make sure, and the generated manifest files remain the same
There was a problem hiding this comment.
How did you run the generation?
The following command does not change the labels in bundle.Dockerfile and bundle/metadata/annotations.yaml.
make bundle generate api-docs USER=open-telemetry VERSION=0.44.0
There was a problem hiding this comment.
I ran make bundle USER=open-telemetry VERSION=0.44.0; this is what step 2 of RELEASE.md instructs. Should we update the documentation to use your command instead?
There was a problem hiding this comment.
Thanks for the confirmation.
Please revert this change the label should be LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v1.16.0+git if you run the bundle it will get changed to v1.16.0+git.
config/manager/kustomization.yaml
Outdated
| kind: Kustomization | ||
| images: | ||
| - name: controller | ||
| newName: ghcr.io/open-telemetry/opentelemetry-operator/opentelemetry-operator |
There was a problem hiding this comment.
there should not be changes in this file
There was a problem hiding this comment.
Removed; these changes were made during the make bundle command, how can I discern whether or not a change made from there should be included?
bundle/manifests/opentelemetry-operator.clusterserviceversion.yaml
Outdated
Show resolved
Hide resolved
|
CI is failing |
Should be fixed now! |
|
@erichsueh3 the changelog needs to be updated again |
|
@pavolloffay @VineethReddy02 just updated the changelog |
|
@erichsueh3 could you please take a look at this comment https://github.com/open-telemetry/opentelemetry-operator/pull/719/files#r811677921 |
Just took a look and left a comment there |
|
The |
* OTEL Operator release 0.44.0 * removed changes to kustomization.yaml * removed sdk version changes * Added to CHANGELOG * update changelog * revert LABEL in bundle.Dockerfile
Resolves #700 for Operator release v0.44.0