Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including new label #797

Merged
merged 8 commits into from
Apr 5, 2022
Merged

Conversation

yuriolisa
Copy link
Contributor

Signed-off-by: Yuri Sa yurimsa@gmail.com

Resolves #394

Signed-off-by: Yuri Sa <yurimsa@gmail.com>
@yuriolisa yuriolisa requested a review from a team March 24, 2022 12:58
pkg/collector/labels.go Outdated Show resolved Hide resolved
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
@yuriolisa yuriolisa requested a review from Aneurysm9 April 1, 2022 08:53
yuriolisa and others added 5 commits April 1, 2022 11:02
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Signed-off-by: Yuri Sa <yurimsa@gmail.com>
@ringerc
Copy link

ringerc commented May 16, 2022

I think this broke deployments that deploy containers with sha256 hashes. A k8s label is limited to 63 characters, and a sh256 hash is 64 characters, resulting in errors like `

failed to reconcile config maps","error":"failed to reconcile the expected configmaps: failed to apply changes: ConfigMap \"otel-collector\" is invalid: metadata.labels: Invalid value: \"8f65b4d94bb5290c8fc1540703c06f7a7a12cfd917d2f141bdc8a18803828615\": must be no more than 63 characters"

@ringerc
Copy link

ringerc commented May 17, 2022

Yeah, this introduced a breaking regression per #879 @yuriolisa @jpkrohling

ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
…elemetry#797)

* Including new label

Signed-off-by: Yuri Sa <yurimsa@gmail.com>

* Checking len of version var

Signed-off-by: Yuri Sa <yurimsa@gmail.com>

* Fixing function signature

Signed-off-by: Yuri Sa <yurimsa@gmail.com>

* Fixing linters

Signed-off-by: Yuri Sa <yurimsa@gmail.com>

* Fixing number of labels in test files

Signed-off-by: Yuri Sa <yurimsa@gmail.com>

* Test len of label version for configmap

Signed-off-by: Yuri Sa <yurimsa@gmail.com>

* Added missing len check

Signed-off-by: Yuri Sa <yurimsa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing labels in ConfigMap and Lease
5 participants