-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter encoding issue #930
Fix parameter encoding issue #930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small nitpick, else lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@pavolloffay, could you please merge it? |
@@ -2,17 +2,18 @@ package allocation | |||
|
|||
import ( | |||
"math" | |||
logf "sigs.k8s.io/controller-runtime/pkg/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be moved to the second group
* logging * Fixed encoding issue of params * Do string replacement * Another test * Removed dockerfile changes * Fix broken test * Newline * Change placement of the log import
The target allocator was only unencoding when a collector_id wasn't provided which made it so that the target for the collector was never returned. This also fixes the issue where the encoded URL wasn't provided correctly to the collectors
Closes #925
Evidence this works: