Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for spec.Env to be set on the OTEL Colelctor Spec #94

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Allow for spec.Env to be set on the OTEL Colelctor Spec #94

merged 1 commit into from
Oct 20, 2020

Conversation

ekarlso
Copy link
Contributor

@ekarlso ekarlso commented Oct 20, 2020

  • Some of the extensions like Kubernetes Observer requires you to set some
    ENV vars
  • Be useful for things like getting API Tokens via Vault etc.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 20, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

jpkrohling
jpkrohling reviewed Oct 20, 2020
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing test, looks good to me.

pkg/collector/container.go Outdated Show resolved Hide resolved
jpkrohling
jpkrohling approved these changes Oct 20, 2020
View reviewed changes
Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling
Copy link
Member

Once you sort the EasyCLA check, it should be merged automatically by mergify. Thanks for the contribution!

@ekarlso
Allow for spec.Env to be set on the OTEL Colelctor Spec
d591a85 
* Some of the extensions like Kubernetes Observer requires you to set some
  ENV vars
* Be useful for things like getting API Tokens via Vault etc.
@mergify mergify bot merged commit cf02ede into open-telemetry:master Oct 20, 2020
@ekarlso ekarlso deleted the spec-env-support branch October 20, 2020 12:25
shree007 pushed a commit to shree007/opentelemetry-operator that referenced this pull request Dec 12, 2021
@ekarlso
Allow for spec.Env to be set on the OTEL Colelctor Spec (open-telemet…
67160d3 
…ry#94)

* Some of the extensions like Kubernetes Observer requires you to set some
  ENV vars
* Be useful for things like getting API Tokens via Vault etc.
ItielOlenick pushed a commit to ItielOlenick/opentelemetry-operator that referenced this pull request May 1, 2024
@ekarlso
Allow for spec.Env to be set on the OTEL Colelctor Spec (open-telemet…
e000901 
…ry#94)

* Some of the extensions like Kubernetes Observer requires you to set some
  ENV vars
* Be useful for things like getting API Tokens via Vault etc.
dt-cloner bot pushed a commit to IshwarKanse/opentelemetry-operator that referenced this pull request Oct 7, 2024
@openshift-merge-bot
Merge pull request open-telemetry#94 from IshwarKanse/rebase-bot-main
c139587 
Merge https://github.com/open-telemetry/opentelemetry-operator:main (91759b0) into main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekarlso @jpkrohling