chore(nodejs): update to 0.31.0 #955
Conversation
|
@mat-rumian, rather than switch the exporter, would be possible to create a kind of parameter that the end-user will be capable to decide? |
mat-rumian
changed the title
|
@yuriolisa OTLP HTTP json is the most used exporter for JS community - 3x times more than gRPC based on the npmjs package repository statistics. I think it was also the first implemented exporter for OT JS. I also asked on the OT-JS community channel which exporter they consider as "default" one. |
| @@ -1,5 +1,5 @@ | |||
| import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node'; | |||
| import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-grpc'; | |||
| import { OTLPTraceExporter } from '@opentelemetry/exporter-trace-otlp-http'; | |||
There was a problem hiding this comment.
What is the URL/endpoint that needs to be set for the HTTP exporter in nodejs?
There was a problem hiding this comment.
Note that right now there are no e2e tests that would actually verify data is reported. The tests only assert the service started and the injection of libraries worked.
|
@pavolloffay @yuriolisa so after some talks on OT-JS channel it came out that there's a fix for I propose to wait till new exporter will be released and then update the PR and do not change exporter. |
|
@mat-rumian, I guess we could proceed further with this PR due to open-telemetry/opentelemetry-js#3019 was already merged. |
mat-rumian
changed the title
|
@yuriolisa I've updated |
* chore(nodejs): bump deps, switch exporter to OTLP HTTP proto * chore(nodejs): switch exporter to OTLP HTTP json * chore(instrumentation): get back to grpc exporter
PR update OT NodeJS dependencies to the latest
OTLP gRPCexporter and instrumentations