Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 8.2 + 8.3 to build matrix #1107

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Conversation

brettmc
Copy link
Collaborator

@brettmc brettmc commented Aug 31, 2023

8.3 is in RC, so add it to the matrix.
bump 8.2 to non-experimental, which should have happened some time ago.

8.3 is in RC, so add it to the matrix. currently failing because many libraries do not
support it yet. bump 8.2 to non-experimental, which should have happened some time ago.
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #1107 (d9f8023) into main (197a7a4) will increase coverage by 0.45%.
Report is 4 commits behind head on main.
The diff coverage is 72.32%.

❗ Current head d9f8023 differs from pull request most recent head 25de72c. Consider uploading reports for the commit 25de72c to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1107      +/-   ##
============================================
+ Coverage     83.05%   83.50%   +0.45%     
- Complexity     2151     2160       +9     
============================================
  Files           278      279       +1     
  Lines          6119     6136      +17     
============================================
+ Hits           5082     5124      +42     
+ Misses         1037     1012      -25     
Flag Coverage Δ
7.4 82.12% <72.32%> (+0.45%) ⬆️
8.0 83.43% <72.32%> (+0.45%) ⬆️
8.1 83.57% <72.32%> (+0.45%) ⬆️
8.2 83.57% <72.32%> (+0.45%) ⬆️
8.3 83.57% <72.32%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/API/Behavior/Internal/LogWriter/Formatter.php 100.00% <100.00%> (ø)
src/API/Behavior/LogsMessagesTrait.php 100.00% <100.00%> (ø)
src/API/Globals.php 94.28% <100.00%> (-0.59%) ⬇️
src/API/Instrumentation/Configurator.php 100.00% <ø> (ø)
src/API/Instrumentation/ContextKeys.php 100.00% <ø> (ø)
src/Contrib/Otlp/OtlpHttpTransportFactory.php 75.00% <ø> (ø)
...ommon/Adapter/HttpDiscovery/DependencyResolver.php 100.00% <ø> (+8.33%) ⬆️
src/SDK/Common/Export/Http/PsrTransportFactory.php 78.26% <100.00%> (ø)
src/SDK/Common/Export/Http/PsrUtils.php 92.42% <100.00%> (+1.04%) ⬆️
src/SDK/SdkAutoloader.php 93.75% <ø> (-0.19%) ⬇️
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ff5ad...25de72c. Read the comment docs.

@brettmc brettmc marked this pull request as ready for review August 31, 2023 03:32
@brettmc brettmc requested a review from a team August 31, 2023 03:32
@brettmc brettmc marked this pull request as draft September 4, 2023 03:25
@brettmc
Copy link
Collaborator Author

brettmc commented Sep 4, 2023

converting back to draft, to be continued after GA and when 8.3 is closer to GA

@pdelewski
Copy link
Member

converting back to draft, to be continued after GA and when 8.3 is closer to GA

I was thinking about that too, otherwise we will have failing tests.

@bobstrecansky bobstrecansky marked this pull request as ready for review October 4, 2023 12:05
@brettmc brettmc changed the title adding 8.3 to build matrix adding 8.2 + 8.3 to build matrix Oct 4, 2023
@brettmc brettmc merged commit 75bb45f into open-telemetry:main Oct 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants