Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hook manager registration to API package #1402

Merged

Conversation

Nevay
Copy link
Contributor

@Nevay Nevay commented Oct 13, 2024

Makes extension hook manager available via SPI even if SDK is not installed.

Not removing registration in SDK to not break API 1.1.0 w/ SDK >1.1.0.

Keeping registration in SDK to not break API >1.1.0 w/ SDK 1.1.0.
@Nevay Nevay requested a review from a team as a code owner October 13, 2024 15:47
Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for opentelemetry-php canceled.

Name Link
🔨 Latest commit ae7ec6c
🔍 Latest deploy log https://app.netlify.com/sites/opentelemetry-php/deploys/670bebaea5437b000834314b

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.79%. Comparing base (cd8c0e3) to head (ae7ec6c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1402      +/-   ##
============================================
- Coverage     73.85%   73.79%   -0.07%     
  Complexity     2672     2672              
============================================
  Files           386      386              
  Lines          7650     7650              
============================================
- Hits           5650     5645       -5     
- Misses         2000     2005       +5     
Flag Coverage Δ
8.1 73.49% <ø> (-0.01%) ⬇️
8.2 73.73% <ø> (-0.08%) ⬇️
8.3 73.64% <ø> (-0.02%) ⬇️
8.4 73.67% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd8c0e3...ae7ec6c. Read the comment docs.

@brettmc brettmc merged commit f29277a into open-telemetry:main Oct 13, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants