Skip to content

Commit

Permalink
Changes to the experimental profiles protocol based on implementation…
Browse files Browse the repository at this point in the history
… experience.

Change attribute field names and types.
  • Loading branch information
jhalliday committed Sep 12, 2024
1 parent 8b51162 commit 048570c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions opentelemetry/proto/profiles/v1experimental/profiles.proto
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ message ResourceProfiles {
string schema_url = 3;
}

// A collection of ProfileContainers produced by an InstrumentationScope.
// A collection of Profiles produced by an InstrumentationScope.
message ScopeProfiles {
// The instrumentation scope information for the profiles in this message.
// Semantically when InstrumentationScope isn't set, it is equivalent with
Expand Down Expand Up @@ -424,7 +424,7 @@ message Sample {
// [deprecated, superseded by attributes]
repeated Label label = 3;
// References to attributes in Profile.attribute_table. [optional]
repeated int32 attributes = 10;
repeated int32 attribute_indices = 10;

// Reference to link in Profile.link_table. [optional]
int32 link = 12;
Expand Down Expand Up @@ -486,7 +486,7 @@ message Mapping {
// Specifies the kind of build id. See BuildIdKind enum for more details [optional]
BuildIdKind build_id_kind = 11;
// References to attributes in Profile.attribute_table. [optional]
repeated uint64 attributes = 12;
repeated int32 attribute_indices = 12;
// The following fields indicate the resolution of symbolic info.
bool has_functions = 7;
bool has_filenames = 8;
Expand Down Expand Up @@ -528,7 +528,7 @@ message Location {
int32 type_strindex = 6;

// References to attributes in Profile.attribute_table. [optional]
repeated uint64 attributes = 7;
repeated int32 attributes_indices = 7;
}

// Details a specific line in a source code, linked to a function.
Expand Down

0 comments on commit 048570c

Please sign in to comment.