Skip to content

Commit

Permalink
Fix expected URL in aiohttp instrumentation test
Browse files Browse the repository at this point in the history
The underlying cause of the issue here is the update of the yarl package
from 1.8.2 to 1.9.1. yarl is used as a dependency in the
opentelemetry-instrumentation-aiohttp package but it is not there where
the issue happens, but in aiohttp who also has yarl as a dependency.

This is why the fix does not touch any relevant part of any
opentelemetry-* code, since it is the return value of aiohttp code who
now has a different value for the URL.

Fixes #1770
  • Loading branch information
ocelotl committed Apr 24, 2023
1 parent 654f774 commit 3c24a50
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def test_status_codes(self):
(span_status, None),
{
SpanAttributes.HTTP_METHOD: "GET",
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path?query=param#foobar",
SpanAttributes.HTTP_URL: f"http://{host}:{port}/test-path#foobar",
SpanAttributes.HTTP_STATUS_CODE: int(
status_code
),
Expand Down

0 comments on commit 3c24a50

Please sign in to comment.