Fixed after CR

open-telemetry · Jul 27, 2022 · 471dadf · 471dadf
1 parent f4261ba
commit 471dadf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py b/...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
@@ -66,8 +66,8 @@ def response_hook(span, request, response):
 
 import contextlib
 import typing
-from typing import Collection
 from timeit import default_timer
+from typing import Collection
 
 import urllib3.connectionpool
 import wrapt
@@ -205,7 +205,7 @@ def instrumented_urlopen(wrapped, instance, args, kwargs):
             with _suppress_further_instrumentation():
                 start_time = default_timer()
                 response = wrapped(*args, **kwargs)
-                elapsed_time = (default_timer() - start_time) * 1000
+                elapsed_time = round((default_timer() - start_time) * 1000)
 
             _apply_response(span, response)
             if callable(response_hook):
@@ -227,12 +227,14 @@ def instrumented_urlopen(wrapped, instance, args, kwargs):
                 )
 
             request_size = 0 if body is None else len(body)
+            response_size = int(response.headers.get("Content-Length", 0))
+
             duration_histogram.record(elapsed_time, attributes=metric_labels)
             request_size_histogram.record(
                 request_size, attributes=metric_labels
             )
             response_size_histogram.record(
-                len(response.data), attributes=metric_labels
+                response_size, attributes=metric_labels
             )
 
             return response

diff --git a/...pentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/version.py b/...pentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/version.py
@@ -12,4 +12,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-__version__ = "0.33b0"
+__version__ = "0.32b0"
diff --git a/instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py b/instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py
@@ -12,10 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+from timeit import default_timer
+
 import urllib3
 import urllib3.exceptions
 from urllib3.request import encode_multipart_formdata
-from timeit import default_timer
 
 from opentelemetry import trace
 from opentelemetry.instrumentation.urllib3 import URLLib3Instrumentor
@@ -197,7 +198,7 @@ def test_basic_metric_check_client_size_post(self):
                                 self.assertAlmostEqual(
                                     data_point.sum,
                                     client_duration_estimated,
-                                    delta=5000,
+                                    delta=1000,
                                 )
                             self.assertIn(metric.name, expected_metrics)