make some monkey-patching conditional on the version of SQLAlchemy

open-telemetry · Nov 21, 2024 · ab6c5e4 · ab6c5e4
1 parent 7e1a976
commit ab6c5e4
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/...metry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py b/...metry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/__init__.py
@@ -181,13 +181,15 @@ def _instrument(self, **kwargs):
                 tracer, connections_usage, enable_commenter, commenter_options
             ),
         )
-        _w(
-            "sqlalchemy.engine.create",
-            "create_engine",
-            _wrap_create_engine(
-                tracer, connections_usage, enable_commenter, commenter_options
-            ),
-        )
+        # sqlalchemy.engine.create is not present in earlier versions of sqlalchemy (which we support)
+        if parse_version(sqlalchemy.__version__).release >= (1, 4):
+            _w(
+                "sqlalchemy.engine.create",
+                "create_engine",
+                _wrap_create_engine(
+                    tracer, connections_usage, enable_commenter, commenter_options
+                ),
+            )
         _w(
             "sqlalchemy.engine.base",
             "Engine.connect",
@@ -231,7 +233,8 @@ def _instrument(self, **kwargs):
     def _uninstrument(self, **kwargs):
         unwrap(sqlalchemy, "create_engine")
         unwrap(sqlalchemy.engine, "create_engine")
-        unwrap(sqlalchemy.engine.create, "create_engine")
+        if parse_version(sqlalchemy.__version__).release >= (1, 4):
+            unwrap(sqlalchemy.engine.create, "create_engine")
         unwrap(Engine, "connect")
         if parse_version(sqlalchemy.__version__).release >= (1, 4):
             unwrap(sqlalchemy.ext.asyncio, "create_async_engine")