Make span attributes available to sampler in aiohttp_client #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes opentelemetry-python-contrib#939
nstawski
force-pushed
the
ns-939-make-requests-span-attributes-available-to-samplers-for-aiohttp-client
branch
from
b977d89 to
295a6cb
Compare
nstawski
changed the title
nstawski
changed the title
nstawski
changed the title
|
@nstawski is this WIP? If so, please mark the PR as draft 🙂 |
srikanthccv
reviewed
Apr 28, 2022
...-instrumentation-aiohttp-client/src/opentelemetry/instrumentation/aiohttp_client/__init__.py
Outdated
Show resolved
Hide resolved
…rc/opentelemetry/instrumentation/aiohttp_client/__init__.py Co-authored-by: Srikanth Chekuri <srikanth.chekuri92@gmail.com>
nstawski
changed the title
srikanthccv
approved these changes
Apr 28, 2022
srikanthccv
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes span attributes available in aiohttp_client at span start.
Fixes #939
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.