Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to instrument multiple sqlalchemy engines #1132

Merged

Conversation

hemma
Copy link
Contributor

@hemma hemma commented Jun 14, 2022

Description

Fixes #1103

Type of change

Please delete options that are not relevant.

  • [ X ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [ X ] tox -e test-instrumentation-sqlalchemy14
  • [ X ] tox

Does This PR Require a Core Repo Change?

  • [ X ] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • [ X ] Followed the style guidelines of this project
  • [ X ] Changelogs have been updated
  • [ X ] Unit tests have been added
  • [ X ] Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@hemma hemma marked this pull request as ready for review June 14, 2022 19:56
@hemma hemma requested a review from a team June 14, 2022 19:56
@ocelotl ocelotl merged commit f03bef2 into open-telemetry:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sqlalchemy] instrumenting multiple sqlalchemy engines
2 participants