Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sanitizing HTTP header values. #1253

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

rogersd
Copy link
Contributor

@rogersd rogersd commented Aug 30, 2022

Description

First step of #1184

This provides basic support to allow for sanitizing of HTTP headers. Future commits will add code to the various instrumentations that use this functionality.

Fixes #1184

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test added.

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rogersd rogersd requested a review from a team August 30, 2022 16:47
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 30, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rogersd / name: Dan Rogers (3ab583f)

@rogersd rogersd force-pushed the drogers-add-sanitize-class branch 2 times, most recently from 2ec2ac7 to 3ab583f Compare August 30, 2022 17:40
@rogersd
Copy link
Contributor Author

rogersd commented Sep 9, 2022

@srikanthccv @lzchen Could you please take a look at this so I can continue opening PRs?

@rogersd rogersd force-pushed the drogers-add-sanitize-class branch from 3a356ec to e479167 Compare September 12, 2022 18:07
@srikanthccv srikanthccv enabled auto-merge (squash) September 13, 2022 07:59
@srikanthccv srikanthccv merged commit 4d341e8 into open-telemetry:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more features for adding HTTP request / response headers to spans.
2 participants