-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix enable_commenter functionality #1440
Merged
srikanthccv
merged 13 commits into
open-telemetry:main
from
avzis:fix-enable_commenter-in-sql-alchemy
Dec 6, 2022
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b1ae34f
fix enable_commenter functionality
avzis 789c0b6
update changelog
avzis 7efbea3
update changelog
avzis 797eee4
lint
avzis 59494c5
Merge branch 'main' into fix-enable_commenter-in-sql-alchemy
srikanthccv 4629273
lint
avzis 3fdcb96
Merge branch 'fix-enable_commenter-in-sql-alchemy' of github.com:avzi…
avzis 6cde413
Merge branch 'main' into fix-enable_commenter-in-sql-alchemy
avzis 9b42b61
add tests
avzis 3b33434
Merge branch 'main' into fix-enable_commenter-in-sql-alchemy
avzis 9535dce
reverse
avzis 79e7b8e
Merge branch 'main' into fix-enable_commenter-in-sql-alchemy
srikanthccv f200289
changelog
avzis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default parameters here are redundant, since they are always passed from the callee funtions