-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(asgi-instrumentation): extract target after running the framework #1461
Merged
Commits on Nov 19, 2022
-
fix(asgi-instrumentation): extract target after running the framework
There was a mistake in the original strategy to extract the feature, as before running the framework the scope does not have all the information necessary to deduct the route. We move the target extraction after running the framewrork function, but that means that we won't have those attributes for the span or for the active_requests metrics. The target will be available only for the duration metric. The test was also updated to reflect that the scope changes only after running the framework function.
Configuration menu - View commit details
-
Copy full SHA for 23a670c - Browse repository at this point
Copy the full SHA 23a670cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c41392 - Browse repository at this point
Copy the full SHA 8c41392View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e802ac - Browse repository at this point
Copy the full SHA 0e802acView commit details
Commits on Nov 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 510d082 - Browse repository at this point
Copy the full SHA 510d082View commit details
Commits on Nov 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6886ab4 - Browse repository at this point
Copy the full SHA 6886ab4View commit details
Commits on Dec 3, 2022
-
Now the target attribute is only present in the duration metric
Configuration menu - View commit details
-
Copy full SHA for 6d01689 - Browse repository at this point
Copy the full SHA 6d01689View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29bc7c0 - Browse repository at this point
Copy the full SHA 29bc7c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75d19b1 - Browse repository at this point
Copy the full SHA 75d19b1View commit details
Commits on Dec 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f1fadae - Browse repository at this point
Copy the full SHA f1fadaeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.