Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(asgi-instrumentation): extract target after running the framework #1461

Merged
merged 9 commits into from
Dec 5, 2022

Commits on Nov 19, 2022

  1. fix(asgi-instrumentation): extract target after running the framework

    There was a mistake in the original strategy to extract the feature, as before running the framework the scope does not have all the information necessary to deduct the route.
    
    We move the target extraction after running the framewrork function, but that means that we won't have those attributes for the span or for the active_requests metrics. The target will be available only for the duration metric.
    
    The test was also updated to reflect that the scope changes only after running the framework function.
    sk- committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    23a670c View commit details
    Browse the repository at this point in the history
  2. Add changelog

    sk- committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    8c41392 View commit details
    Browse the repository at this point in the history
  3. fix fastapi tests

    sk- committed Nov 19, 2022
    Configuration menu
    Copy the full SHA
    0e802ac View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Configuration menu
    Copy the full SHA
    510d082 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Configuration menu
    Copy the full SHA
    6886ab4 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2022

  1. fix asgi metric test

    Now the target attribute is only present in the duration metric
    sk- committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    6d01689 View commit details
    Browse the repository at this point in the history
  2. fix test

    sk- committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    29bc7c0 View commit details
    Browse the repository at this point in the history
  3. fix fastapi test

    sk- committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    75d19b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2022

  1. Configuration menu
    Copy the full SHA
    f1fadae View commit details
    Browse the repository at this point in the history