Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TortoiseORM instrumentation] Fix AttributeError: type object 'Config' has no attribute 'title' #1575

Conversation

fullonic
Copy link
Contributor

@fullonic fullonic commented Jan 12, 2023

Description

The attribute title from PydanticModel.Config is optional, however, this instrumentation assumes that it will be present, which will raise an AttributeError when missing. To avoid forcing users to add the title attribute for all pydantic models, this PR adds the model name as the default title value.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual test

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • [x ] No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@fullonic fullonic requested a review from a team January 12, 2023 09:41
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 12, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: fullonic / name: dbf (c34b011)

@srikanthccv srikanthccv enabled auto-merge (squash) February 6, 2023 11:38
@srikanthccv srikanthccv merged commit 7af87e1 into open-telemetry:main Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants