Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit and test opentelemetry-instrumentation-django NoOpTracerProvider #1611

Merged
merged 10 commits into from
Feb 13, 2023
Merged

Audit and test opentelemetry-instrumentation-django NoOpTracerProvider #1611

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9d71ea5
Audit and test opentelemetry-instrumentation-django NoOpTracerProvider
Akochavi Jan 30, 2023
5d6a299
wip
Akochavi Feb 5, 2023
b4b5b25
wip
Akochavi Feb 5, 2023
4eba29a
wip
Akochavi Feb 5, 2023
36699a8
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 5, 2023
1739156
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
srikanthccv Feb 10, 2023
e1751a9
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 11, 2023
58fd962
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 13, 2023
d4e74eb
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
shalevr Feb 13, 2023
1008db4
Merge branch 'main' into audit-and-test-opentelemetry-instrumentation…
srikanthccv Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions instrumentation/opentelemetry-instrumentation-django/tests/test_middleware_asgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from django.test import SimpleTestCase
from django.test.utils import setup_test_environment, teardown_test_environment

from opentelemetry import trace as trace_api
from opentelemetry.instrumentation.django import (
DjangoInstrumentor,
_DjangoMiddleware,
Expand Down Expand Up @@ -424,6 +425,16 @@ async def test_tracer_provider_traced(self):
span.resource.attributes["resource-key"], "resource-value"
)

async def test_no_op_tracer_provider(self):
_django_instrumentor.uninstrument()
_django_instrumentor.instrument(
tracer_provider=trace_api.NoOpTracerProvider()
)

await self.async_client.post("/traced/")
spans = self.exporter.get_finished_spans()
self.assertEqual(len(spans), 0)


@patch.dict(
"os.environ",
Expand Down