Audit and test opentelemetry-instrumentation-elasticsearch NoOpTracer… #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemoshlag
reviewed
Feb 2, 2023
| '{"found": false, "timed_out": true, "took": 7}', | ||
| ) | ||
| es = Elasticsearch() | ||
| es.get(index="test-index", doc_type="_doc", id=1) |
There was a problem hiding this comment.
I suggest validating es.get response value -> so we'll know for sure that no spans were created due to NoOpTracerProvider
…-elasticsearch-no-op-tracer
Akochavi
force-pushed
the
audit-and-test-opentelemetry-instrumentation-elasticsearch-no-op-tracer
branch
from
b0afd30 to
4be4c43
Compare
shalevr
reviewed
Feb 5, 2023
| @@ -24,6 +24,7 @@ | |||
|
|
|||
| import opentelemetry.instrumentation.elasticsearch | |||
| from opentelemetry import trace | |||
| from opentelemetry import trace as trace_api | |||
There was a problem hiding this comment.
trace already imported in the upper line
shalevr
approved these changes
Feb 14, 2023
srikanthccv
reviewed
Feb 15, 2023
| @@ -37,7 +37,7 @@ | |||
|
|
|||
| major_version = elasticsearch.VERSION[0] | |||
|
|
|||
| if major_version == 7: | |||
| if major_version 7: | |||
There was a problem hiding this comment.
I think so, I don't know who pushed this change but I will revert it
…-elasticsearch-no-op-tracer
Akochavi
force-pushed
the
audit-and-test-opentelemetry-instrumentation-elasticsearch-no-op-tracer
branch
from
ffed02e to
34475e1
Compare
…-elasticsearch-no-op-tracer
…-elasticsearch-no-op-tracer
…-elasticsearch-no-op-tracer
shalevr
added a commit
to shalevr/opentelemetry-python-contrib
that referenced
this pull request
Feb 23, 2023
…/github.com/shalevr/opentelemetry-python-contrib into Change-metrics-tests-to-work-with-test_base * 'Change-metrics-tests-to-work-with-test_base' of https://github.com/shalevr/opentelemetry-python-contrib: Fix issue with Flask instrumentation when a request spawn children threads and copies the request context (open-telemetry#1654) Add connection attributes to sqlalchemy connect span (open-telemetry#1608) Add boto3sqs to docs (open-telemetry#1666) Audit and test opentelemetry-instrumentation-elasticsearch NoOpTracer… (open-telemetry#1616) Copy change log updates from release/v1.16.x-0.37bx (open-telemetry#1683) Update version to 1.17.0.dev/0.38b0.dev (open-telemetry#1677) Fix CI Failure (open-telemetry#1680) Add better debugging if hatch subprocess fails (open-telemetry#1672) Add confluent kafka docs (open-telemetry#1668) Support aio_pika 9 (open-telemetry#1670) Audit and test opentelemetry-instrumentation-wsgi NoOpTracerProvider (open-telemetry#1610) bot (open-telemetry#1667) Add commit method for ConfluentKafkaInstrumentor's ProxiedConsumer (open-telemetry#1656) Revert open-telemetry#1097 (open-telemetry#1660) Audit and test opentelemetry-instrumentation-django NoOpTracerProvider (open-telemetry#1611) Audit and test opentelemetry-instrumentation-aiohttp-client NoOpTrace… (open-telemetry#1612) Audit and test opentelemetry-instrumentation-flask NoOpTracerProvider (open-telemetry#1614) Audit and test opentelemetry-instrumentation-dbapi NoOpTracerProvider (open-telemetry#1607)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for elasticsearch using NoOpTracerProvider
Fixes #984
How has this been tested?
tox -e test-instrumentation-elasticsearch