Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add propagator injection for botocore calls #181

Merged

Conversation

NathanielRN
Copy link
Contributor

Description

Calls using the botocore SDK now use the global propagator to inject context into the request headers before they are sent to AWS.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added a unit test to verify a function which wraps Endpoint.prepare_request gets called and inserts a value using the global propagator

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
    - [ ] Documentation has been updated

@NathanielRN NathanielRN requested review from a team, toumorokoshi and lzchen and removed request for a team November 12, 2020 22:23
@NathanielRN NathanielRN force-pushed the botocore-propagation-injection branch 7 times, most recently from b78b33a to b82627b Compare November 12, 2020 23:57
@NathanielRN NathanielRN force-pushed the botocore-propagation-injection branch from b82627b to 8ee114b Compare November 13, 2020 00:06
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

@lzchen lzchen merged commit acf5706 into open-telemetry:master Nov 13, 2020
@NathanielRN NathanielRN deleted the botocore-propagation-injection branch November 25, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants