Update asyncpg instrumentation to follow semantic conventions #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
a team,
codeboten and
hectorhdzg
and removed request for
a team
lzchen
reviewed
Nov 17, 2020
.../opentelemetry-instrumentation-asyncpg/src/opentelemetry/instrumentation/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Nov 17, 2020
.../opentelemetry-instrumentation-asyncpg/src/opentelemetry/instrumentation/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Nov 17, 2020
Don't make function call unnecessarily when span is not recording
…39/opentelemetry-python-contrib into asyncpg-semantic-conv
lzchen
approved these changes
Nov 17, 2020
NathanielRN
reviewed
Nov 23, 2020
.../opentelemetry-instrumentation-asyncpg/src/opentelemetry/instrumentation/asyncpg/__init__.py
Outdated
Show resolved
Hide resolved
NathanielRN
reviewed
Nov 23, 2020
Comment on lines
+63
to
+69
| if isinstance(addr, tuple): | ||
| span_attributes["net.peer.name"] = addr[0] | ||
| span_attributes["net.peer.ip"] = addr[1] | ||
| span_attributes["net.transport"] = "IP.TCP" | ||
| elif isinstance(addr, str): | ||
| span_attributes["net.peer.name"] = addr | ||
| span_attributes["net.transport"] = "Unix" |
There was a problem hiding this comment.
Nit: Are there any docs explaining how to parse these out? I think they could be useful to add to the function doc string for _hydrate_span_from_args
There was a problem hiding this comment.
Connection contains _addr attribute which is either a host/port tuple, or Unix socket string. May be something like this?
…telemetry/instrumentation/asyncpg/__init__.py Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <enruizno@uwaterloo.ca>
nstawski
pushed a commit
to nstawski/ns-opentelemetry-python-contrib
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #159
Type of change
How Has This Been Tested?
tox -e test-instrumentation-asyncpg