Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fixes broken contrib tests] Add metrics renaming changes to contrib #192

Conversation

AzfaarQureshi
Copy link
Contributor

@AzfaarQureshi AzfaarQureshi commented Nov 19, 2020

Description

This PR makes the corresponding renaming changes from otel-python open-telemetry/opentelemetry-python#1372 in the contrib to fix failing tests as noted here: open-telemetry/opentelemetry-python#1372 (comment)

cc - @alolita

@AzfaarQureshi AzfaarQureshi requested review from a team, toumorokoshi and hectorhdzg and removed request for a team November 19, 2020 16:12
@AzfaarQureshi AzfaarQureshi changed the title Add metrics renaming changes to contrib [fixes broken contrib tests] Add metrics renaming changes to contrib Nov 19, 2020
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for doing this.

@codeboten codeboten merged commit cd0be91 into open-telemetry:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants