-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.12 to tox #2116
Add 3.12 to tox #2116
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,13 +16,14 @@ jobs: | |
py39: 3.9 | ||
py310: "3.10" | ||
py311: "3.11" | ||
py312: "3.12" | ||
pypy3: pypy-3.8 | ||
RUN_MATRIX_COMBINATION: ${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }} | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false # ensures the entire test matrix is run, even if one permutation fails | ||
matrix: | ||
python-version: [py38, py39, py310, py311, pypy3] | ||
python-version: [py38, py39, py310, py311, py312, pypy3] | ||
package: | ||
# Do not add more instrumentations here, add them in instrumentations_1.yml. | ||
# The reason for this separation of instrumentations into more than one YAML file is | ||
|
@@ -79,6 +80,8 @@ jobs: | |
- python-version: py310 | ||
package: "sklearn" | ||
- python-version: py311 | ||
# package: "sklearn" | ||
# - python-version: py312 | ||
package: "sklearn" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to add
|
||
- python-version: pypy3 | ||
package: "aiopg" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,13 +16,14 @@ jobs: | |
py39: 3.9 | ||
py310: "3.10" | ||
py311: "3.11" | ||
py312: "3.12" | ||
pypy3: pypy-3.8 | ||
RUN_MATRIX_COMBINATION: ${{ matrix.python-version }}-${{ matrix.package }}-${{ matrix.os }} | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false # ensures the entire test matrix is run, even if one permutation fails | ||
matrix: | ||
python-version: [py38, py39, py310, py311, pypy3] | ||
python-version: [py38, py39, py310, py311, py312, pypy3] | ||
package: | ||
- "urllib" | ||
- "urllib3" | ||
|
@@ -39,6 +40,8 @@ jobs: | |
exclude: | ||
- python-version: py311 | ||
package: "prometheus-remote-write" | ||
# - python-version: py312 | ||
# package: "prometheus-remote-write" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unsure about this "exclude section" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the test works fine here with python 3.12. Plenty of warnings but tox is happy
|
||
- python-version: pypy3 | ||
package: "prometheus-remote-write" | ||
steps: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ classifiers = [ | |
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. boto is abandonded and so won't work with 3.12 |
||
] | ||
dependencies = [ | ||
"opentelemetry-api ~= 1.12", | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,7 @@ classifiers = [ | |
"Programming Language :: Python :: 3.9", | ||
"Programming Language :: Python :: 3.10", | ||
"Programming Language :: Python :: 3.11", | ||
"Programming Language :: Python :: 3.12", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It does not work with that and there aren't newer releases |
||
] | ||
dependencies = [ | ||
"opentelemetry-api ~= 1.5", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about this "exclude section"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine to be excluded, tests fails too trying to bump to scikit-learn 1.0.x (that is still an old version)