[boto3sqs] Instrument Session and resource
#2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the following open issues: - open-telemetry#1699 - open-telemetry#1996 There are four ways to access the SQS API via `boto3`: - `client = boto3.client("sqs")` - `client = boto3.Session().client("sqs")` - `sqs = boto3.resource("sqs")` - `sqs = boto3.Session().resource("sqs")` The existing wrapper tied into `boto3.client` to wrap a generated `botocore.client.SQS` class. The change here covers the three missing initialization methods.
mattoberle
force-pushed
the
boto3sqs/resource
branch
from
26dfe09 to
6bfaf34
Compare
ocelotl
approved these changes
Feb 12, 2024
There are actually 6 ways to initialize a boto3 API object. ```py boto3.client() # Using default global session boto3.resource() # Using default global session boto3.Session().client() # Using "re-exported" session.Session boto3.Session().resource() # Using "re-exported" session.Session boto3.session.Session().client() # Using session.Session directly boto3.session.Session().resource() # Using session.Session directly ``` We only have to patch `session.Session.client` to catch all the cases. - https://github.com/boto/boto3/blob/b3c158c62aa2a1314dc0ec78caea1ea976abd1a0/boto3/session.py#L217-L229 - https://github.com/boto/boto3/blob/b3c158c62aa2a1314dc0ec78caea1ea976abd1a0/boto3/session.py#L446-L457
|
Just a note: Read through the relevant boto3 source and optimized this a bit from the initial commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are six ways to access the SQS API via
boto3:client = boto3.client("sqs")client = boto3.Session().client("sqs")sqs = boto3.resource("sqs")sqs = boto3.Session().resource("sqs")sqs = boto3.session.Session().client("sqs")sqs = boto3.session.Session().resource("sqs")The existing wrapper tied into
boto3.clientto wrap a generatedbotocore.client.SQSclass.The change here targets the deeper
session.Session.clientmethod, extending instrumentation to the remaining 5 initialization strategies.Fixes #1699
Fixes #1996
Type of change
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist: