Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields method #226

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Add fields method #226

merged 2 commits into from
Dec 2, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Nov 30, 2020

Fixes #224

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@ocelotl ocelotl self-assigned this Nov 30, 2020
@ocelotl ocelotl requested review from a team, toumorokoshi and lzchen and removed request for a team November 30, 2020 23:42
@ocelotl ocelotl force-pushed the issue_224 branch 3 times, most recently from 6506c8f to 87bcbbf Compare December 1, 2020 00:09
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need an entry in the changelog for the aws sdk?

@ocelotl
Copy link
Contributor Author

ocelotl commented Dec 1, 2020

Does this need an entry in the changelog for the aws sdk?

Added this changelog entry.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@NathanielRN NathanielRN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you 😄

Also, maybe a test that compares the fields returned by fields() and the fields set after an inject would be helpful?

sdk-extension/opentelemetry-sdk-extension-aws/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: (Eliseo) Nathaniel Ruiz Nowell <enruizno@uwaterloo.ca>
@codeboten codeboten merged commit 8b323e9 into open-telemetry:master Dec 2, 2020
@NathanielRN
Copy link
Contributor

NathanielRN commented Dec 2, 2020

Here is the Core repo PR: open-telemetry/opentelemetry-python#1374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fields property
3 participants