Repeated headers list for ASGI frameworks #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2024
xrmx
reviewed
Mar 20, 2024
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Show resolved
Hide resolved
|
@samuelcolvin please rebase |
|
Okay, think this is good. I got so confused about all the wsgi based web frameworks, some use enviroment variables to pass request headers (and repsonse headers? 🤷 ) some don't, sometimes. It's not helped by the fact that lots of the tests combine "multiple" headers into one key-value pair with comma separation. I therefore reverted all the changes in wsgi and flask, and concentrated on getting the ASGI based frameworks right. |
samuelcolvin
changed the title
srikanthccv
approved these changes
May 9, 2024
xrmx
reviewed
May 9, 2024
instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py
Outdated
Show resolved
Hide resolved
util/opentelemetry-util-http/src/opentelemetry/util/http/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
May 14, 2024
|
Hey gentle ping, are you still working on this? |
|
Sorry, I've been busy and dropped the ball, I'll try to fix soon.
Samuel
…On Wed, 5 Jun 2024, 19:20 Leighton Chen, ***@***.***> wrote:
@samuelcolvin <https://github.com/samuelcolvin>
Hey gentle ping, are you still working on this?
—
Reply to this email directly, view it on GitHub
<#2361 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA62GGJJ2B6XQPELBV7F56LZF5JGLAVCNFSM6AAAAABE7Y4VZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGY4DCMZVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
ocelotl
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use a list, rather than a comma separate string to represent repeated HTTP request and response headers.
fixes #2360
fixes #2358
followup to #2266
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tests updated
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.