-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
elasticsearch: stop testing on ancient versions #2422
elasticsearch: stop testing on ancient versions #2422
Conversation
Looking at the stats there are still 100K downloads a month for elasticsearch5, may just drop just 2. Still there are not have been releases since 2019. |
5 has been EOL since 2019 though, probably not many people using opentelemetry with it. |
e87f599
to
a78a753
Compare
I think it's fair to drop 5 support, then also add a changelog entry under |
daed9f7
to
fa36331
Compare
Done |
@ocelotl I have in the pipeline testing for newer elasticsearch versions so the version is useful to keep |
Pick 6.0 as the baseline.
b5a2b6d
to
f6f307a
Compare
We are no longer using package versions in the naming of test requirements files, if more testing is added for elasticsearch that uses different versions, the test requirements files are numbered from |
AFAIR there was agreement that reinstating the more semantic versioning after your PRs reworking tests was fine. |
Description
Pick 6.0 as the baseline. Elasticsearch 2 client was EOL in 2018, Elasticsearch 5 in 2019.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.