Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistently use of suppress_instrumentation utils #2590

Merged
merged 8 commits into from
Jun 14, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Jun 8, 2024

Description

According to this search, some instrumentations aren't using the suppression_instrumentation util properly. Found these ones:

  • opentelemetry-instrumentation-httpx
  • opentelemetry-instrumentation-aiohttp-serve

Please let me know if I missed something.

Fixes #2543

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@emdneto emdneto changed the title Ensure consistently use of suppress_instrumentation utils consistently use of suppress_instrumentation utils Jun 8, 2024
@emdneto emdneto marked this pull request as ready for review June 8, 2024 21:05
@emdneto emdneto requested a review from a team June 8, 2024 21:05
CHANGELOG.md Outdated Show resolved Hide resolved
@emdneto emdneto requested a review from xrmx June 10, 2024 13:57
CHANGELOG.md Outdated Show resolved Hide resolved
emdneto and others added 3 commits June 11, 2024 16:33
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@emdneto emdneto requested review from lzchen and xrmx June 14, 2024 16:32
@lzchen lzchen merged commit 6be205e into open-telemetry:main Jun 14, 2024
365 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suppress_instrumentation utils are not used consistently
4 participants