Add additional attributes for redis.search methods create_index, search

[mpozniak95]

Description

Add additional attributes for redisearch methods: redis.commands.search, create_index:

For create_index method: https://redis-py.readthedocs.io/en/stable/redismodules.html#redis.commands.search.commands.SearchCommands.create_index
Attributes:

• fields - to show from which fields index was created

For search method: https://redis-py.readthedocs.io/en/stable/redismodules.html#redis.commands.search.commands.SearchCommands.search
Attributes:

• query - shows query string
• total - shows number of documents returned
• xdoc{index} - shows returned documents

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Added functional tests for these methods

Does This PR Require a Core Repo Change?

• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: lzchen / name: Leighton Chen (7b5bd19, fd52a83, 5a1a1d5, 87374e4, 6bf2b22, 6a8bc22, f889861, c3fc628)
• ✅ login: mpozniak95 / name: Marcin Poźniak (16d99e0, adc4263, 59b7c91, a9e5afc, 191ef9d, da7ae34, 4cb2415, 15e09d3, 5507098, 748022a, 23b2736, c53b08e, ae5f1a3, 2ad9768, 8c6c75d, c1d0d7f, cc52746, fb3ba66)

[lzchen]

@mpozniak95

I am not too familiar with the inner workings of Redis. Could you update the description of the PR to be more descriptive of why are we making these changes? Is the plan to add INTERNAL spans or should these calls be treated as DATABASE spans?

[mpozniak95]

Idea is to integrate it with: https://github.com/traceloop/openllmetry. Since those three methods are probably the most used Redis methods in LLM applications we would like to have additional attributes in spans of that methods.

[lzchen]

@mpozniak95

Please update the description of the pr to reflect what you are trying to do. I am not familiar with the inner workings of https://github.com/traceloop/openllmetry so please summarize exactly what you are trying to do and what new methods you are trying to trace (linking to redis docs would be most helpful as well).

Is the plan to add INTERNAL spans or should these calls be treated as DATABASE spans?

You are currently also creating INTERNAL spans for the current implementation. Is this correct or should we treating the spans as CLIENT with type database which follows database semantic conventions

[mpozniak95]

You are right the spans should be CLIENT type, I changed it. I also edited the description

[mpozniak95]

I changed the implementation to catch those functions in _traced_execute_command and edit their span_name and attributes. Also for now I deleted the aggregate from the PR, I will add it in separate PR once we merge this.

I feel that it got a little complicated right now, it was easy to extract the response from redis.commands.search function directly (because it was already parsed by _parse_response function in redis package) but execute_command returns unparsed response. I added some comments to the code (I hope they make any sense, maybe it will be easier to review)

[lzchen]

LGTM. @mpozniak95 Please add a CHANGELOG entry and we can get this merged!

[mpozniak95]

So, can we merge it :)?