Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to instrument httpx when using proxy #2664

Merged
merged 10 commits into from
Jul 17, 2024
Merged

Add support to instrument httpx when using proxy #2664

merged 10 commits into from
Jul 17, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Jul 5, 2024 •
edited
Loading

Description

Fixes #2341
Credits to @joumenharzli for the analysis of the issue and the original idea.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@emdneto emdneto marked this pull request as ready for review July 5, 2024 18:36
@emdneto emdneto requested a review from a team July 5, 2024 18:36
@emdneto
Copy link
Member Author

emdneto commented Jul 13, 2024

@joumenharzli, could you please also take a look at this?

@lzchen lzchen merged commit e6c27e0 into open-telemetry:main Jul 17, 2024
377 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhihali zhihali zhihali approved these changes

@lzchen lzchen lzchen approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

httpx instrumentation does not work when proxy is set
4 participants
@emdneto @xrmx @lzchen @zhihali