-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TraceState #276
Merged
codeboten
merged 10 commits into
open-telemetry:master
from
srikanthccv:trace-state-fix
Jan 20, 2021
Merged
Update TraceState #276
codeboten
merged 10 commits into
open-telemetry:master
from
srikanthccv:trace-state-fix
Jan 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
requested review from
a team,
owais and
aabmass
and removed request for
a team
December 24, 2020 10:31
9 tasks
srikanthccv
commented
Dec 24, 2020
@@ -1,4 +1,4 @@ | |||
DD_ORIGIN = "_dd_origin" | |||
DD_ORIGIN = "dd_origin" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Key must start with alphabet or digit as per specs.
Ooh, I wonder if the change from dict to tuple affects the issue in #262 too, I'll have to test this. |
lzchen
approved these changes
Jan 7, 2021
@lonewolf3739 |
codeboten
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of open-telemetry/opentelemetry-python#1502