Fix http.host and net.peer.ip new http semconv mapping
#2814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
changed the title
emdneto
reviewed
Aug 22, 2024
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
emdneto
reviewed
Aug 22, 2024
opentelemetry-instrumentation/src/opentelemetry/instrumentation/_semconv.py
Show resolved
Hide resolved
emdneto
changed the title
http.host and net.peer.ip new http semconv mapping
emdneto
reviewed
Aug 23, 2024
emdneto
approved these changes
Aug 23, 2024
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.hostold semantic convention should map to different new semantic convention depending on if they areclientorservertype telemetry. See spec for details.Also updates
net.peer.ip->client.addresslogic to be conditional only if it doesn't exist already. This is outlined in the migration doc net.peer.ip -> net.sock.peer.addr → network.peer.address.