Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to allow topic to be passed via kwargs #2901

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

bourbonkk
Copy link
Contributor

@bourbonkk bourbonkk commented Oct 11, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

This PR fixes an issue where the topic argument in the produce() method of ConfluentKafkaProducer was not being correctly extracted when passed as a keyword argument (kwargs).

Changes:

  • Updated the KafkaPropertiesExtractor.extract_produce_topic function to correctly handle topic passed via kwargs.
  • Simplified the logic for extracting the topic from args or kwargs for better readability and efficiency.
  • Added relevant test cases to ensure that the topic is properly extracted when passed via both positional (args) and keyword (kwargs) arguments.

Fixes #2083

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • � Added test code to verify that topics are properly collected by span

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@bourbonkk bourbonkk requested a review from a team as a code owner October 11, 2024 15:35
@bourbonkk bourbonkk requested a review from emdneto October 14, 2024 02:12
@xrmx xrmx merged commit cef28d6 into open-telemetry:main Oct 22, 2024
528 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KafkaPropertiesExtractor not extracting topic from kwargs
4 participants