opentelemetry-instrumentation-system-metrics: don't report open file descriptors on windows #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrmx
force-pushed
the
fix-system-metrics-win
branch
from
6fd85dd to
bdef60b
Compare
…riptors on windows
xrmx
force-pushed
the
fix-system-metrics-win
branch
from
bdef60b to
76c8452
Compare
xrmx
changed the title
emdneto
approved these changes
Nov 4, 2024
xrmx
force-pushed
the
fix-system-metrics-win
branch
from
695ece2 to
cd03f86
Compare
emdneto
reviewed
Nov 4, 2024
.github/workflows/generate_workflows_lib/src/generate_workflows_lib/__init__.py
Show resolved
Hide resolved
tammy-baylis-swi
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't report open file descriptors on Windows because file descriptors are not available there.
Fixes #2870
Closes #2895
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.